Fix WebGL render target resizing - #3344
Conversation
a3e80fe to
e4eddf8
Compare
|
LGTM! I'm ready to merge my PR. Since I'm going to squash the commits, would you like to change the target branch to jb-main after I merge my PR? This way your authorship will be preserved. Looks like I can change the target branch myself. I'll try. |
|
I see... When I merged my PR, it automatically deleted the branch too which was the target branch of your PR. And that's why your PR got closed too. My bad. Could you please re-open your PR against jb-main? (The button is inactive for me). I managed to re-open it. But got merge conflicts now. I'll appreciate your help with them :) |
|
Will do in a bit. Just need to rebase on jb-main and drop the down stack (squashed) commits |
e4eddf8 to
39eb351
Compare
|
Marking Release Notes as N/A since it's fixing a new feature which has not been released yet. |
|
Thanks! I tested resize in the CMP webgl demos. Works well! |
dca97b2
into
JetBrains:jb-main
Fix
WebGLRenderTargetrendering after its size changes.Image.adoptTextureFromtransfers ownership of the WebGL texture to Skia, so closing the old image deletes that texture. The previous resize path then tried to allocate storage on the deleted texture, which left the framebuffer incomplete. This change creates a texture for each size generation and releases the previous texture through one path after notifying borrowers.PR #3323 and its Skiko update are now on
jb-main. This PR is the focused resize follow-up.Testing
In this repo:
./gradlew :compose:ui:ui:jsBrowserTest --no-daemon --no-configuration-cache./gradlew :mpp:publishComposeJbToMavenLocal -Pcompose.platforms=web -Pjetbrains.publication.libraries=COMPOSE --no-daemon --no-configuration-cacheIn maplibre/maplibre-compose#1114:
Release Notes
N/A