[JEWEL-1069] Implement slim button #3360
Open
+419
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wellingtoncosta
requested review from
faogustavo and
rock3r
and removed request for
rock3r
wellingtoncosta
force-pushed
the
wp/slim-button
branch
from
018413d to
8ec611c
Compare
faogustavo
suggested changes
Jan 2, 2026
Collaborator
faogustavo
left a comment
faogustavo
left a comment
There was a problem hiding this comment.
Same as the ad text. Just make sure to follow the deprecation cycle (keeping a method with the old signature to prevent breaking changes) and make sure you update the API Dumps
| menuStyle: MenuStyle = MenuStyle.dark(), | ||
| outlinedButtonStyle: ButtonStyle = ButtonStyle.Outlined.dark(), | ||
| defaultSlimButtonStyle: ButtonStyle = ButtonStyle.Slim.dark(), | ||
| outlinedSlimButtonStyle: ButtonStyle = ButtonStyle.Slim.dark(colors = ButtonColors.Outlined.dark()), |
wellingtoncosta
force-pushed
the
wp/slim-button
branch
from
8ec611c to
c5eae77
Compare
rock3r
reviewed
Jan 10, 2026
| private fun buttonCornerSize(): CornerSize = CornerSize(DarculaUIUtil.BUTTON_ARC.dp.safeValue() / 2) | ||
|
|
||
| private fun createSlimButtonStyle(colors: ButtonColors): ButtonStyle { | ||
| return ButtonStyle( |
Collaborator
There was a problem hiding this comment.
Nit: please use expression style
| focusOutlineExpand: Dp = 1.5.dp, | ||
| ): ButtonMetrics = ButtonMetrics(cornerSize, padding, minSize, borderWidth, focusOutlineExpand) | ||
|
|
||
| public val ButtonStyle.Companion.Slim: IntUiSlimButtonStyleFactory |
Collaborator
There was a problem hiding this comment.
If you want to have the Slim factory — which is a good idea — we need to have an API that looks the same as the non-slim variants. This means you need something like:
public val ButtonStyle.Companion.Slim: IntUiSlimButtonStyleFactory
public object IntUiSlimButtonStyleFactory {
val Outlined = IntUiSlimOutlinedButtonStyleFactory
val Default = IntUiSlimDefaultButtonStyleFactory
}
public object IntUiSlimOutlinedButtonStyleFactory {
public fun light(...): ButtonStyle = ...
public fun dark(...): ButtonStyle = ...
}
public object IntUiSlimDefaultButtonStyleFactory {
public fun light(...): ButtonStyle = ...
public fun dark(...): ButtonStyle = ...
}
Comment on lines
+183
to
+184
| * **Swing equivalent:** [`JButton`](https://docs.oracle.com/javase/tutorial/uiswing/components/button.html) with | ||
| * reduced insets |
Collaborator
There was a problem hiding this comment.
"with reduced insets" is wrong — it is a JButton for which DarculaButtonUi.isSmallVariant(button) returns true. That is, it has b.getClientProperty("ActionToolbar.smallVariant") == true
| * **Usage example:** | ||
| * [`Buttons.kt`](https://github.com/JetBrains/intellij-community/blob/master/platform/jewel/samples/standalone/src/main/kotlin/org/jetbrains/jewel/samples/standalone/view/component/Buttons.kt) | ||
| * | ||
| * **Swing equivalent:** [`JButton`](https://docs.oracle.com/javase/tutorial/uiswing/components/button.html) with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new button variant called
SlimButton, which has bothdefaultandoutlinedstyles and it's intended to be used in toolbars and space-constrained UIs. As part of the public API, there are bothDefaultSlimButtonandOutlinedSlimButton, following the pattern for other button variants.A slim button section was added to the sample app, showcasing how it looks like.
Release notes
New features
SlimButton, which has bothDefaultSlimButtonandOutlinedSlimButtonstylesNote
Adds a compact button variant for space-constrained UIs.
DefaultSlimButtonandOutlinedSlimButtoncomponents with reduced padding/height (24dp) and toolbar-friendly metricsButtonMetrics.slimandButtonStyle.Slimfactories in Int UI stylingdefaultSlimButtonStyle/outlinedSlimButtonStyleviaJewelTheme, composition locals, andDefaultComponentStyling; integrates into IntUi themes and Swing bridge readersWritten by Cursor Bugbot for commit 018413d. This will update automatically on new commits. Configure here.