[JEWEL-1199] Fixed issues with JewelComposePanelWrapper and SwingInterop #3368
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faogustavo
requested review from
daaria-s,
nebojsa-vuksic,
rock3r and
wellingtoncosta
faogustavo
force-pushed
the
gv/JEWEL-1199
branch
from
f1cd80f to
641e982
Compare
- When the user clicks into some interop component inside the ComposePanel, the focus was being automatically stolen - The old logic was testing if the clicked component was a child of the compose panel wrapper (at any level) - However, that logic does not work well when we have interop with swing components - To fix that problem, the check now validates if the click happened in the "SwingSkiaLayer", by checking if the parent component is the compose panel - This ensures focus requests from interop components are correctly handled rather than intercepted/stolen
faogustavo
force-pushed
the
gv/JEWEL-1199
branch
from
641e982 to
3f56af2
Compare
wellingtoncosta
approved these changes
Jan 8, 2026
daaria-s
approved these changes
Jan 9, 2026
rock3r
approved these changes
Jan 10, 2026
Collaborator
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Bug fixes