[JEWEL-1221] TabStrip should not change the size when scrollbar appear #3376
+93
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using the HorizontallyScrollableContainer causes a minor ui glitch as the component getts bigger to accomodate the scrollbar - To prevent this issue to happen, I'm rollabacking to manually create the scrollbar and use a box instead - This is needed because the default guidelines mandate a space for the scrollbar, however the implementation for tabstrip should render over the tabs
faogustavo
requested review from
DanielSouzaBertoldi,
daaria-s,
nebojsa-vuksic,
rock3r and
wellingtoncosta
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| modifier = Modifier.semantics { hideFromAccessibility() }, | ||
| ) { | ||
| HorizontalScrollbar(scrollState, style = style.scrollbarStyle, modifier = Modifier.fillMaxWidth()) | ||
| } |
There was a problem hiding this comment.
Scrollbar appears when content doesn't need scrolling
Medium Severity
The AnimatedVisibility visibility condition only checks tabStripState.isHovered, but the old HorizontallyScrollableContainer also checked scrollState.canScroll to ensure the scrollbar only appears when the content actually needs scrolling. The new implementation will show a scrollbar when hovering even if there are only a few tabs and no scrolling is needed, which differs from the intended behavior where the scrollbar should only appear when content overflows.
faogustavo
force-pushed
the
gv/JEWEL-1221
branch
from
94c437f to
8fdbcd0
Compare
wellingtoncosta
approved these changes
Jan 9, 2026
rock3r
reviewed
Jan 10, 2026
Collaborator
rock3r
left a comment
rock3r
left a comment
There was a problem hiding this comment.
Would like a screenrecording or two to validate the behaviour :)
| enter = | ||
| fadeIn( | ||
| tween( | ||
| durationMillis = scrollbarVisibility.trackColorAnimationDuration.inWholeMilliseconds.toInt(), |
Collaborator
There was a problem hiding this comment.
Shouldn't this be the thumb animation duration? Same below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Note
Ensures the
TabStripno longer resizes when the scrollbar appears by rendering a hover‑activated overlay scrollbar and using nativehorizontalScroll.HorizontallyScrollableContainerwith aBox+RowusinghorizontalScroll; addsAnimatedVisibilityfade forHorizontalScrollbarand hides it from accessibilitytestTags and a new test assertingTabStripheight remains constant while adding many tabs; minor test setup optimization withderivedStateOfWritten by Cursor Bugbot for commit 8fdbcd0. This will update automatically on new commits. Configure here.