Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix JVM toolchain download #473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonathanlermitage
Copy link

The build.gradle.kts defines a JVM toolchain, but if no compatible JDK is found, no JDK is downloaded and the build fails.
To download a JDK automatically if needed, we need the org.gradle.toolchains.foojay-resolver-convention plugin. Tested on Arch Linux, with JDK21 installed: after adding the foojay plugin, ./gradlew buildPlugin no longer fails, and it downloads a compatible JDK17.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.92%. Comparing base (ae35708) to head (dbe7b10).
Report is 85 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   27.58%   26.92%   -0.67%     
==========================================
  Files           4        4              
  Lines          29       26       -3     
==========================================
- Hits            8        7       -1     
+ Misses         21       19       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants