Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KT-69327] Correct FloatingPointParser.initialParse method to handle specific cases with invalid exponent string value #5322

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OptimumCode
Copy link

Hi, this PR should close KT-69327 issue.

Unfortunately, I was not able to run tests:
I executed ./gradlew install and then JAVA_OPTS=-Didea.sync.active=true ./gradlew -p libraries/stdlib nativeTest but got a compilation error related to classes in kotlin-native/runtime/src/main/kotlin directory.

If anyone knows how to execute the kotlin-native/runtime/test/text/StringNumberConversionNativeTest.kt test I would much appreciate it if you help me with that.

Please, let me know if anything else should be done in order to submit this PR.

@fzhinkin
Copy link
Contributor

@OptimumCode

Unfortunately, I was not able to run tests:

The following command should start native stdlib tests: ./gradlew :native:native.tests:stdlibTest -Pkotlin.native.enabled=true

@OptimumCode
Copy link
Author

Thank you, @fzhinkin. Works like a charm. All native stdlib tests are green

@ilya-g ilya-g self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants