Suggested workaround for KT-81241 #5509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsocv12
force-pushed
the
fix/emptyListErrorLowering
branch
2 times, most recently
from
b35db97 to
7ff8e92
Compare
alfonsocv12
force-pushed
the
fix/emptyListErrorLowering
branch
from
7ff8e92 to
e9c2cf3
Compare
ivandev0
reviewed
Oct 8, 2025
There was a problem hiding this comment.
Hi! Thank you for the contribution! I will close this PR because your change is not entirely correct. Please take a look at this and the following commits for the proper solution.
How you can improve in the future.
- Always add tests. If you take a look at my commits, you will see that I added tests before fixing anything to show that they are falling. After the fix these tests started to pass, and this is reflected in the commit itself.
- Don't rush with changes. The root cause of the issue was in a different place, and the method itself is fine.
- Check out the contribution guide.
|
Fixed in b9202f7 |
|
Hello @ivandev0 thank you very much for the suggestions and taking the time to resolve this issue. Even with this not being the right fix for the issue, I think the error message Is to obscure to debug, maybe adding this change, but throw an error instead, could be better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if target.typeParameters gracefully.
I started seeing the failures after updating from 2.3.0-dev-423 to 2.3.0-dev-7988, this is a workaround, the difference that I see in my debugging is that a lot more things are hitting the IrUtils.copyTo from createBridge