Enable EGL #68
Open
Enable EGL #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2025
eymar
reviewed
Jun 6, 2025
script/build.py
Outdated
| 'skia_use_system_icu=false', | ||
| 'skia_enable_skottie=true' | ||
| 'skia_enable_skottie=true', | ||
| 'skia_use_egl=true' |
There was a problem hiding this comment.
I am not sure if this has any side effects for other platforms. Alternatively, I could enable it only for Linux arm64.
I expect that enabling it for all platforms would just increase the binary size.
I think it's better to enable it only for the targets where it's required right now.
There was a problem hiding this comment.
@eymar Alright, now it is enabled only for linuxArm64 target where it is needed.
eymar
approved these changes
Jun 6, 2025
|
Hey @eymar, I rebased the PR on main. Could you please check if that resolves the build issues by triggering the workflow? |
|
@eymar I triggered a run on my fork and it shows no issues: https://github.com/Thomas-Vos/skia-pack/actions/runs/17074207122 |
|
Approved CI run (Oleksandr is on vacation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for my linuxArm64 device which only support EGL.
https://youtrack.jetbrains.com/issue/SKIKO-918
I am not sure if this has any side effects for other platforms. Alternatively, I could enable it only for Linux arm64.