Skip to content

Fixed adding a new library jsonreader (skjsonreader) + reverting to 9e6b5bff162 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

Fixed adding a new library jsonreader (skjsonreader) + reverting to 9e6b5bff162 #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45685c8
fixed adding a new library jsonreader (skjsonreader)
mazunin-v-jb Aug 7, 2025
528df5f
review fixes
mazunin-v-jb Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:
contents: write

env:
version: m138-c1caa59365c-1
version: m138-9e6b5bff162-2

jobs:
macos:
Expand Down
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,21 @@ Prebuilt binaries can be found [in releases](https://github.com/JetBrains/skia-p
3. Update `version` in [.github/workflows/build.yml](https://github.com/JetBrains/skia-pack/blob/master/.github/workflows/build.yml).

## Building locally

Replace SKIA_VERSION with the version you want to build, for example `m138-9e6b5bff162`.
Note: Better check build.yml for the detailed command for your machine

```sh
python3 script/checkout.py --version m138-9e6b5bff162
python3 script/checkout.py --version SKIA_VERSION
python3 script/build.py
python3 script/archive.py --version m138-9e6b5bff162
python3 script/archive.py --version SKIA_VERSION
```

To build a debug build:

```sh
python3 script/checkout.py --version m138-9e6b5bff162
python3 script/checkout.py --version SKIA_VERSION
python3 script/build.py --build-type Debug
python3 script/archive.py --version m138-9e6b5bff162 --build-type Debug
python3 script/archive.py --version SKIA_VERSION --build-type Debug
```

### Windows-specific
Expand Down
1 change: 1 addition & 0 deletions script/archive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def main():
'modules/skcms/*.h',
'modules/skunicode/include/*.h',
'modules/skunicode/src/*.h',
'modules/jsonreader/*.h',
'src/base/*.h',
'src/core/*.h',
'src/gpu/ganesh/gl/*.h',
Expand Down