feat(manager): move and update metrics cards in the server view #2241

daniellacosse · 2024-10-14T15:34:32Z

server_manager/www/shadowbox_server.ts

fortuna

This is very helpful to see how the API is used. I believe we will benefit a lot from merging the stats flows into one.

server_manager/index.html

server_manager/messages/master_messages.json

server_manager/model/server.ts

server_manager/www/app.ts

daniellacosse

Updated with the new endpoint JSON: will merge methods next

server_manager/messages/master_messages.json

server_manager/www/app.ts

fortuna

As discussed offline, Per-ASN breakdown was a significant gap during the Iran crisis. It's a confirmed need and and we put a lot of effort to implement it. It's more of a question of how, not whether we want to surface that.

I would like to see that surfaced somehow in this PR, to inform the UX design. We've discussed a simple table, which seems to work well.

daniellacosse · 2024-11-15T18:03:30Z

As discussed offline, Per-ASN breakdown was a significant gap during the Iran crisis. It's a confirmed need and and we put a lot of effort to implement it. It's more of a question of how, not whether we want to surface that.

I would like to see that surfaced somehow in this PR, to inform the UX design. We've discussed a simple table, which seems to work well.

Sure thing, working on it!

daniellacosse · 2024-11-15T19:43:22Z

As discussed offline, Per-ASN breakdown was a significant gap during the Iran crisis. It's a confirmed need and and we put a lot of effort to implement it. It's more of a question of how, not whether we want to surface that.

I would like to see that surfaced somehow in this PR, to inform the UX design. We've discussed a simple table, which seems to work well.

Here's an initial PR for a data table component: #2273

daniellacosse · 2025-01-21T21:36:20Z

@fortuna @sbruens ready for another look!

server_manager/www/shadowbox_server.ts

Co-authored-by: Sander Bruens <[email protected]>

server_manager/model/server.ts

fortuna · 2025-01-28T18:46:00Z

server_manager/www/testing/models.ts

+      new Error('FakeServer.getServerMetrics not implemented')
+    );
+  }
+  getSupportedExperimentalEndpoints(): Promise<Set<string>> {


This can be private.

And you can turn it into a boolean for the specific endpoint you are checking.

making it private in the test classes messes up the inheritance in TS - but I made it private on shadowbox_server

server_manager/model/server.ts

server_manager/www/app.ts

server_manager/www/shadowbox_server.ts

Co-authored-by: Vinicius Fortuna <[email protected]>

daniellacosse · 2025-01-29T20:31:19Z

server_manager/www/shadowbox_server.ts

+
+    try {
+      await this.api.request<MetricsJson>(
+        'experimental/server/metrics?since=30d'


@sbruens HEAD gave 405 (Method Not Allowed) and OPTIONS returned a 404 - is there another HTTP Method I can use that the server supports?

OPTIONS sounds like the perfect method for this!

Ah, I'm so used to most web servers having middleware that configure the right HEAD and OPTIONS by default. Agree OPTIONS is even more appropriate.

fortuna

Looks good. The OPTIONS situation is unfortunate, that would be ideal. But I think we don't register an OPTIONS handler.

fortuna · 2025-01-29T21:33:47Z

server_manager/www/shadowbox_server.ts

+
+    try {
+      await this.api.request<MetricsJson>(
+        'experimental/server/metrics?since=30d'


OPTIONS sounds like the perfect method for this!

fortuna · 2025-01-29T21:35:44Z

server_manager/index.html

+
+    <style>
+      /* 
+        TODO: currently webpack wants to relove the `url` link here but doesen't know how.


Suggested change

TODO: currently webpack wants to relove the `url` link here but doesen't know how.

TODO: currently webpack wants to relove the `url` link here but doesn't know how.

sbruens · 2025-01-30T15:28:43Z

server_manager/www/shadowbox_server.ts

+
+    try {
+      await this.api.request<MetricsJson>(
+        'experimental/server/metrics?since=30d'


Ah, I'm so used to most web servers having middleware that configure the right HEAD and OPTIONS by default. Agree OPTIONS is even more appropriate.

sbruens · 2025-01-30T15:35:14Z

server_manager/www/ui_components/outline-server-view.ts

@@ -1066,6 +1129,35 @@ export class ServerView extends DirMixin(PolymerElement) {
    return formatting.formatBytesParts(totalBytes, language).value;
  }

+  _formatHourUnits(hours: number, language: string) {
+    // This happens during app startup before we set the language


This is because we don't set a default value for the property in the Polymer property lifecycle. We should set it properly and then you should be able to remove this.

* feat(manager): move and update metrics cards in the server view * getting close. trying to figure out this weird data model * style update * don't use reduce lol * okay it roughly works end to end * add metrics messages * access key tab * update to use new "endpoint" - feedback next * feedback * endpoint implemented * Update server_manager/www/app.ts Co-authored-by: Vinicius Fortuna <[email protected]> * Update server_manager/model/server.ts Co-authored-by: Vinicius Fortuna <[email protected]> * partial feedback * feedback - needs test * move implementatino * fix * fix unit formatting * refactor for testing * Update server_manager/www/shadowbox_server.ts Co-authored-by: Sander Bruens <[email protected]> * partial feedback * simply method and remove from model * make private --------- Co-authored-by: Vinicius Fortuna <[email protected]> Co-authored-by: Sander Bruens <[email protected]>

github-actions bot added size/S size/M and removed size/S labels Oct 14, 2024

daniellacosse commented Oct 16, 2024

View reviewed changes

server_manager/www/shadowbox_server.ts Outdated Show resolved Hide resolved

daniellacosse requested a review from sbruens October 16, 2024 18:07

daniellacosse changed the title ~~feat(manager): move and update metrics cards in the server view~~ feat(manager): [MISSING ENDPOINT] move and update metrics cards in the server view Oct 16, 2024

daniellacosse marked this pull request as ready for review October 16, 2024 18:08

daniellacosse requested review from fortuna and a team as code owners October 16, 2024 18:08

daniellacosse changed the title ~~feat(manager): [MISSING ENDPOINT] move and update metrics cards in the server view~~ feat(manager): [MISSING ENDPOINT - DO NOT MERGE] move and update metrics cards in the server view Oct 16, 2024

fortuna requested changes Oct 30, 2024

View reviewed changes

daniellacosse added 7 commits November 12, 2024 11:08

feat(manager): move and update metrics cards in the server view

90673c3

getting close. trying to figure out this weird data model

51b17e9

style update

4b51e45

don't use reduce lol

8d5d9a5

okay it roughly works end to end

80af4c7

add metrics messages

f30ccc7

access key tab

ee8c388

daniellacosse force-pushed the daniellacosse/tunneltime/move_metrics branch from 55108a4 to ee8c388 Compare November 12, 2024 16:09

update to use new "endpoint" - feedback next

ab29f2c

github-actions bot added size/L and removed size/M labels Nov 12, 2024

daniellacosse commented Nov 12, 2024

View reviewed changes

server_manager/messages/master_messages.json Show resolved Hide resolved

server_manager/messages/master_messages.json Show resolved Hide resolved

server_manager/www/app.ts Outdated Show resolved Hide resolved

feedback

2a6076d

daniellacosse requested a review from fortuna November 12, 2024 18:45

Merge branch 'master' into daniellacosse/tunneltime/move_metrics

23bf19e

fortuna reviewed Nov 15, 2024

View reviewed changes

endpoint implemented

2b1d7da

Merge branch 'master' into daniellacosse/tunneltime/move_metrics

93f0ff5

sbruens reviewed Jan 22, 2025

View reviewed changes

daniellacosse and others added 2 commits January 22, 2025 13:04

Update server_manager/www/shadowbox_server.ts

4de5d2d

Co-authored-by: Sander Bruens <[email protected]>

partial feedback

a8ed3bf

daniellacosse requested a review from sbruens January 22, 2025 18:13

daniellacosse added 2 commits January 22, 2025 13:13

Merge branch 'master' into daniellacosse/tunneltime/move_metrics

be93aba

Merge branch 'master' into daniellacosse/tunneltime/move_metrics

2a8f0fb

fortuna reviewed Jan 28, 2025

View reviewed changes

daniellacosse added 2 commits January 28, 2025 14:10

simply method and remove from model

b101c24

make private

6d02bcc

daniellacosse requested a review from fortuna January 28, 2025 19:14

Merge branch 'master' into daniellacosse/tunneltime/move_metrics

14ce841

daniellacosse enabled auto-merge (squash) January 28, 2025 19:23

daniellacosse removed the needs test Pull requests that require tests label Jan 29, 2025

fortuna reviewed Jan 29, 2025

View reviewed changes

daniellacosse and others added 4 commits January 29, 2025 12:24

Update server_manager/www/shadowbox_server.ts

299ca2f

Co-authored-by: Vinicius Fortuna <[email protected]>

wip - changing branches to check something

e71f87c

Merge branch 'master' into daniellacosse/tunneltime/move_metrics

ae9d71f

okay, time to test

c64e8a0

github-actions bot added size/XL and removed size/L labels Jan 29, 2025

fix issues

60c442e

daniellacosse requested a review from fortuna January 29, 2025 20:29

daniellacosse commented Jan 29, 2025

View reviewed changes

fortuna approved these changes Jan 29, 2025

View reviewed changes

daniellacosse merged commit aee140a into master Jan 29, 2025
25 checks passed

daniellacosse deleted the daniellacosse/tunneltime/move_metrics branch January 29, 2025 21:38

sbruens reviewed Jan 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(manager): move and update metrics cards in the server view #2241

feat(manager): move and update metrics cards in the server view #2241

daniellacosse commented Oct 14, 2024 •

edited

Loading

fortuna left a comment

daniellacosse left a comment

fortuna left a comment

daniellacosse commented Nov 15, 2024

daniellacosse commented Nov 15, 2024

daniellacosse commented Jan 21, 2025

fortuna Jan 28, 2025

fortuna Jan 28, 2025

daniellacosse Jan 28, 2025 •

edited

Loading

daniellacosse Jan 29, 2025

fortuna Jan 29, 2025

sbruens Jan 30, 2025

fortuna left a comment

fortuna Jan 29, 2025

fortuna Jan 29, 2025

sbruens Jan 30, 2025

sbruens Jan 30, 2025

	TODO: currently webpack wants to relove the `url` link here but doesen't know how.
	TODO: currently webpack wants to relove the `url` link here but doesn't know how.

feat(manager): move and update metrics cards in the server view #2241

feat(manager): move and update metrics cards in the server view #2241

Conversation

daniellacosse commented Oct 14, 2024 • edited Loading

fortuna left a comment

Choose a reason for hiding this comment

daniellacosse left a comment

Choose a reason for hiding this comment

fortuna left a comment

Choose a reason for hiding this comment

daniellacosse commented Nov 15, 2024

daniellacosse commented Nov 15, 2024

daniellacosse commented Jan 21, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniellacosse Jan 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fortuna left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniellacosse commented Oct 14, 2024 •

edited

Loading

daniellacosse Jan 28, 2025 •

edited

Loading