Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

Conversation

@fortuna
Copy link
Contributor

@fortuna fortuna commented Feb 1, 2023

This may address some issues with UDP.

Fixes #109.

This may address some issues with UDP.
Fixes #109.
@bemasc
Copy link
Contributor

bemasc commented Feb 1, 2023

Note that this is the upstream read, so network misbehavior has no effect. Any app that retries its UDP packet at least once every 30 seconds will keep the NAT entry open.

Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, is 5min too long for the user to wait for the connection? Suppose the server crashed between CheckUDPConnectivityWithDNS and registerConnectionHandlers, the user might need to wait for at most 5 mins to be successfully connect/disconnect.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove or extend UDP listening timeout

4 participants