Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove phantomjs #106

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

remove phantomjs #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8bc881
rm phantomjs
jimmywarting Dec 27, 2022
c132ef2
rm phantomjs
jimmywarting Dec 27, 2022
656b938
rm phantomjs
jimmywarting Dec 27, 2022
8677b53
rm phantomjs
jimmywarting Dec 27, 2022
164c89b
rm phantomjs
jimmywarting Dec 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
runs-on: ubuntu-latest
env:
PROTRACTOR_BROWSERS: firefox
KARMA_BROWSERS: PhantomJS,Firefox
KARMA_BROWSERS: Firefox
DISPLAY: :99.0
name: Build and run action on on NodeJs 10
steps:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ grunt --help
Run the tests.

__Environment Variables__:
- `KARMA_BROWSERS` overwrite browsers for unit tests (default: PhantomJs,Chrome,Firefox)
- `KARMA_BROWSERS` overwrite browsers for unit tests (default: Chrome,Firefox)
- `KARMA_REPORTERS` overwrite reporters for unit tests (default: progress)

__Options__:
Expand Down
2 changes: 1 addition & 1 deletion lib/getDefaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ module.exports = function getDefaults(grunt, _, path, fs, merged, glob) { // jsh
defaults.dynamicAuthor = false;
defaults.coveragePort = 7000;
defaults.livereloadPort = 35729;
defaults.unitBrowsers = ['Chrome', 'Firefox', 'PhantomJS'];
defaults.unitBrowsers = ['Chrome', 'Firefox'];
defaults.unitReporters = ['progress'];
defaults.autoprefixerBrowsers = [
'last 5 version',
Expand Down
4 changes: 2 additions & 2 deletions lib/tasks/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ module.exports = function() {
' --no-coverage (Default: false)',
' --no-jshint (Default: false)',
' --no-jscs (Default: false)',
' --unit-browsers (Default: Chrome,Firefox,PhantomJS)',
' --unit-browsers (Default: Chrome,Firefox)',
' --unit-reporters (Default: progress)',
' Environment Variables:',
' KARMA_BROWSERS (Default: Chrome,Firefox,PhantomJS)',
' KARMA_BROWSERS (Default: Chrome,Firefox)',
' KARMA_REPORTERS (Default: progress)'
],
options: {
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
"karma-firefox-launcher": "v2.1.2",
"karma-html2js-preprocessor": "^1.0.0",
"karma-jasmine": "^1.0.2",
"karma-phantomjs-launcher": "^1.0.0",
"karma-requirejs": "^1.0.0",
"karma-spec-reporter": "0.0.26",
"node-sass-middleware": "^0.9.8",
Expand Down