Skip to content

Changed allow_nulls defaults to True #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scottbw merged 1 commit into from
Dec 10, 2024
Merged

Changed allow_nulls defaults to True #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mario/data_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def __init__(self,
super().__init__(Configuration(), dataset_specification, metadata)
self.configuration = configuration

def validate_data(self, allow_nulls=False):
def validate_data(self, allow_nulls=True):
from mario.validation import HyperValidator
validator = HyperValidator(
dataset_specification=self.dataset_specification,
Expand Down Expand Up @@ -300,7 +300,7 @@ def stream_sql_to_hyper(self,
table: str = 'Extract',
schema: str = 'Extract',
validate: bool = False,
allow_nulls: bool = False,
allow_nulls: bool = True,
minimise: bool = False,
chunk_size: int = 100000):
"""
Expand Down Expand Up @@ -328,7 +328,7 @@ def stream_sql_to_hyper(self,
def stream_sql_to_csv(self,
file_path,
validate: bool = False,
allow_nulls: bool = False,
allow_nulls: bool = True,
chunk_size: int = 100000,
compress_using_gzip: bool = False,
minimise: bool = False
Expand Down