Skip to content

Commit

Permalink
[RDBSS] Avoid CORE-13938
Browse files Browse the repository at this point in the history
Pierre recommended this workaround for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"

This workaround was recurrently applied for all releases
0.4.8, 0.4.9, 0.4.10, 0.4.11, 0.4.12, 0.4.13.

I never got any reply in the regression-ticket and recurrently
applying this over and over again is a waste of time.
So I decided to commit to master today, but will leave
the ticket unresolved, so when a proper fix will arrive in the future,
the existing ticket will remind us to undo this workaround.

Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.
  • Loading branch information
JoachimHenze committed Apr 2, 2020
1 parent b78cb36 commit 45b5ec8
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions sdk/lib/drivers/rdbsslib/rdbss.c
Original file line number Diff line number Diff line change
Expand Up @@ -8319,6 +8319,16 @@ RxQueryNameInfo(
return STATUS_BUFFER_OVERFLOW;
}

#if 1 // CORE-13938, rfb: please note I replaced 0 with 1 here
if (NodeType(Fcb) == RDBSS_NTC_STORAGE_TYPE_DIRECTORY &&
RxContext->Info.LengthRemaining >= sizeof(WCHAR))
{
NameInfo->FileName[NameInfo->FileNameLength / sizeof(WCHAR)] = L'\\';
NameInfo->FileNameLength += sizeof(WCHAR);
RxContext->Info.LengthRemaining -= sizeof(WCHAR);
}
#endif

/* All correct */
return STATUS_SUCCESS;
}
Expand Down

0 comments on commit 45b5ec8

Please sign in to comment.