Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Notifications: Notifications tab UI fixes #3667

Open
melyndav opened this issue Nov 7, 2024 · 1 comment · May be fixed by #3784
Open

QA Notifications: Notifications tab UI fixes #3667

melyndav opened this issue Nov 7, 2024 · 1 comment · May be fixed by #3784
Assignees
@davecreaser
Labels
bug Something isn't working UI issue Minor user interface issues/ improvements

Comments

@melyndav
Copy link

melyndav commented Nov 7, 2024 •
edited
Loading

Description

All issues raised impact all responsive sizing.

Issue 1: The new notifications tab in the userhub is missing HR's between each notification item as per the design and other userhub tabs.

Currently, in QA:

image

Figma design:

image

Figma

Link to Figma design - https://www.figma.com/design/0Fi3AaDlr3LAXBfsOXBGyk/User-Account?node-id=6754-9622&t=QSsB9RdPVTORnWg3-4

Lin to design system component: https://www.figma.com/design/l1dOM5qiQYwF0ElvKDqqjg/Design-System---Colony-v3?node-id=1782-51509&m=dev

Issue 2: The 'Mark all as read text' is missing a hover state. Please add a gray-900 to this text when hovered on desktop.

image

Issue 3: The padding between the notification heading and first item and in-between each item including the missing HR rule should match Figma.

image

Link component to correct issues: https://www.figma.com/design/l1dOM5qiQYwF0ElvKDqqjg/Design-System---Colony-v3?node-id=1782-51509&t=NHTBNFxfk12vDSQh-4
@melyndav melyndav added bug Something isn't working UI issue Minor user interface issues/ improvements labels Nov 7, 2024
@melyndav melyndav changed the title QA Notifications: Notifications tab in the user hub UI issues QA Notifications: Notifications tab in the user hub UI issues #2 Nov 7, 2024
@rdig rdig mentioned this issue Nov 7, 2024
Closed
@melyndav melyndav changed the title QA Notifications: Notifications tab in the user hub UI issues #2 QA Notifications: Notifications tab UI fixes Nov 7, 2024
@melyndav
Copy link
Author

melyndav commented Nov 7, 2024

FYI: @rdig merged #3519 into this one. Thanks for the nudge.

@davecreaser davecreaser self-assigned this Nov 27, 2024
@davecreaser davecreaser linked a pull request Nov 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davecreaser davecreaser

Labels
bug Something isn't working UI issue Minor user interface issues/ improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Minor UI fixes for notifications tab JoinColony/colonyCDapp
2 participants
@davecreaser @melyndav