Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Minor UI fixes for notifications tab #3784

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davecreaser
Copy link
Contributor

Description

  • Fix some minor UI issues with the notifications tab
    • Add a border bottom to each notification (matching the transactions tab)
    • Add a hover state to the 'Mark all as read' button (gray-900)
    • Align the padding top and bottom of the notifications items with the design (14px or 0.875rem - also matching the transactions tab)

Testing

  • Make a couple of simple payments or mint tokens actions or something simple, so that you have a few notifications.
Screenshot 2024-11-27 at 13 38 47
  • Check that there is a border bottom on each item, which matches the border bottom of the transactions in the transactions tab.

  • Check that when you hover over 'Mark all as read' it turns gray-900

Screenshot 2024-11-27 at 13 40 05
  • Check that the padding top and bottom of each item is correct

Figma:
Screenshot 2024-11-27 at 13 42 35
Screenshot 2024-11-27 at 13 42 43

Localhost:
Screenshot 2024-11-27 at 13 43 05

Diffs

Changes 🏗

  • Classname tweaks to userhub / notifications components

Resolves #3667

@davecreaser davecreaser requested a review from a team as a code owner November 27, 2024 13:45
bassgeta
bassgeta previously approved these changes Nov 28, 2024
Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👌
image
image
Can't see the cursor here, but I have hovered over Mark all as read
image
Shall we add the notification.id to the useMemo deps so we don't get orange triangle warnings in Github 👀 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA Notifications: Notifications tab UI fixes
2 participants