Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: you can't create a motion to transfer funds from a subdomain to the parent domain #3704

Open
bassgeta opened this issue Nov 12, 2024 · 0 comments · May be fixed by #3788
Open

bug: you can't create a motion to transfer funds from a subdomain to the parent domain #3704

bassgeta opened this issue Nov 12, 2024 · 0 comments · May be fixed by #3788
Assignees
Labels
bug Something isn't working

Comments

@bassgeta
Copy link
Contributor

Steps to reproduce

  1. Install and enable the voting reputation extension
  2. Try to create a Transfer funds action moving some CREDS from Andromeda to General
    image
  3. The transaction estimation fails with reason voting-rep-invalid-domain-id

Suggestions (optional)

This happens because our moveFunds action creation doesn't set the third parameter correctly. We should have an action domain which we check permissions for, and then use that. Instead it always uses the fromDomain, but the "action domain" depends on where are we moving funds from and to.
image

While you're at it, change the third parameter of the multisig motion call too, to use the correct "action domain" instead.

@bassgeta bassgeta added the bug Something isn't working label Nov 12, 2024
@bassgeta bassgeta self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant