Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct domain permission proofs for move funds motion #3788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bassgeta
Copy link
Contributor

Description

This PR just uses the new helpers for getting move funds permission proofs for motions and thus fixes the bug 💯

Testing

Best way is to just test everything :D

  1. Install the voting reputation extension
  2. Install the Multi-sig extension, set the global threshold to 1, give leela the Owner/Payer multi-sig role in General
  3. Create a move funds voting reputation motion moving 1 CREDS from Andromeda to General. Fully support it, npm run forward-time 1 and finalize it.
    image
  4. Create a move funds voting reputation motion, moving 1 CREDS from Andromeda to Rocinante. Fully support it, npm run forward-time 1 and finalize it.
    image
  5. Create a move funds voting reputation motion moving 1 CREDS from General to Rocinante. Fully support it, npm run forward-time 1 and finalize it.
    image
    6 7 and 8 are the exact same but for multi-sig :D
    image
    image
    image

Diffs

Changes 🏗

  • the move funds motion saga now uses new helpers to get the action domain and skill indices

Resolves #3704

@bassgeta bassgeta self-assigned this Nov 27, 2024
@bassgeta bassgeta requested a review from a team as a code owner November 27, 2024 14:39
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here, now transfer from subdomains work properly.

Screenshot from 2024-11-28 12-32-21
Screenshot from 2024-11-28 12-32-58
Screenshot from 2024-11-28 12-35-17
Screenshot from 2024-11-28 12-37-01
Screenshot from 2024-11-28 12-39-10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: you can't create a motion to transfer funds from a subdomain to the parent domain
2 participants