feat: add redo to streaming payment #3648
Open
+112
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CzarekDryl
force-pushed
the
feat/streaming-payments-ui
branch
from
df5c2bc
to
6e7f215
Compare
CzarekDryl
force-pushed
the
feat/16079631-streaming-redo
branch
from
d764cee
to
c252cca
Compare
iamsamgibbs
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Nice work on this! I tested every scenario with different start / end conditions I could think of and it is handling them all fine.
The only reason I'm rejecting, is because of this recent PR #3587 which re-enables the redo option from the activity table. Currently here it isn't possible to redo via the activity table. It would be great if the feat/streaming-payments-ui feature branch could be rebased onto master and make sure the redo via activity table functionality is working here. Especially as there is some custom logic in getting the correct values to show.
| const isStartImmediately = | ||
| Math.abs(startTimeDate.getTime() - new Date(createdAt).getTime()) < 60000; | ||
|
|
||
| // console.log({isStartImmediately, startTimeDate, createdAt}); |
iamsamgibbs
approved these changes
Nov 14, 2024
bassgeta
approved these changes
Nov 22, 2024
| @@ -42,6 +42,7 @@ const useActionFormBaseHook: UseActionFormBaseHook = ({ | |||
| validationSchema, | |||
| actionType, | |||
| id, | |||
| transform, | |||
rdig
requested changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
TODO
Resolves #3141