Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: long activity title overflow issue #3773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nortsova
Copy link
Contributor

@Nortsova Nortsova commented Nov 25, 2024

Description

image

Testing

Step 1. Create any motion with the title: 12312321312312312312312312312313123123123123412341234124312
Step 2. Open Activity page
Step 3. Change the screen size to Mobile and check that the title is truncated 🎉
image

Resolves #3433

@Nortsova Nortsova requested a review from a team as a code owner November 25, 2024 15:13
@Nortsova Nortsova self-assigned this Nov 25, 2024
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix here! It does indeed truncate long words without spaces.

Screenshot 2024-11-26 at 09 46 52

However, I'm not sure what is the expected behaviour for long titles which have spaces. On master they currently drop to a new line, and if they are still too long it will truncate at the end of the second line, like this:

Screenshot 2024-11-26 at 09 51 36

On this branch it gets truncated off on the first line (as shown in the first image).

Might just need some clarification on how we should expect these titles with spaces to look.

@davecreaser
Copy link
Contributor

Just to add some more spice to the mix here:

On master there's currently two different behaviours between desktop and mobile for the issue @iamsamgibbs raised (what should happen when there's spaces).

Desktop truncates on one line:
Screenshot 2024-11-27 at 10 26 49

Mobile truncates on two lines:
Screenshot 2024-11-27 at 10 27 27

In my opinion the way it's handled with this fix is the best solution, since then everything is aligned (all devices, and spaces / no spaces). It's also then aligned with the loading skeleton which shows only one line, and I think it works UX wise since this is really just an overview table and if you need to see the full title you can open the action. Having said all that, I agree that it's probably best to check with the design powers that be.

BUT since I like this solution, I'm going to approve it 🙃

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The long title is now truncated on the activity list

Screenshot from 2024-11-27 19-11-12

However, I still see on the action sidebar, after the action has been completed:

Screenshot from 2024-11-27 19-10-51
Screenshot from 2024-11-27 19-11-05

While I know it's not part of the PR, since it's a small change, I'd say you can do it in here.

Thanks

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant to reject the other review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Actions] Long title names overflow in mobile view on Activity Screen
4 participants