-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: long activity title overflow issue #3773
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix here! It does indeed truncate long words without spaces.
However, I'm not sure what is the expected behaviour for long titles which have spaces. On master they currently drop to a new line, and if they are still too long it will truncate at the end of the second line, like this:
On this branch it gets truncated off on the first line (as shown in the first image).
Might just need some clarification on how we should expect these titles with spaces to look.
Just to add some more spice to the mix here: On master there's currently two different behaviours between desktop and mobile for the issue @iamsamgibbs raised (what should happen when there's spaces). Desktop truncates on one line: Mobile truncates on two lines: In my opinion the way it's handled with this fix is the best solution, since then everything is aligned (all devices, and spaces / no spaces). It's also then aligned with the loading skeleton which shows only one line, and I think it works UX wise since this is really just an overview table and if you need to see the full title you can open the action. Having said all that, I agree that it's probably best to check with the design powers that be. BUT since I like this solution, I'm going to approve it 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, meant to reject the other review
Description
Testing
Step 1. Create any motion with the title:
12312321312312312312312312312313123123123123412341234124312
Step 2. Open Activity page
Step 3. Change the screen size to Mobile and check that the title is truncated 🎉
Resolves #3433