Fix: Multi-sig extension settings issues

[iamsamgibbs]

Description

This PR adds an improvement and fixes an issue with the extensions settings tabs.

The extension data is now refetched when saving changes to an extension and properly waits for these updates to be reflected in the database.

The multi-sig custom settings accordion is now open by default if any threshold is different than the colony threshold.

Testing

• Step 1 - Install the Multi-Sig extension
• Step 2 - Change the threshold setting to "Fixed threshold" with a value of 2.

• Step 3 - Without refreshing, navigate to the dashboard, then back to the multi-sig extension page. Check the threshold is still set to 2. (If you really want to be sure the threshold has updated correctly, then go through the extra steps of assigning multi-sig permissions and checking the threshold is as expected)

• Step 4 - Open the "Customize thresholds per team" accordion and set one of the domains to "Majority approval", then click "Save changes"

• Step 5 - Without refreshing, navigate to the dashboard, then back to the multi-sig extension page. Check the "Customize thresholds per team" accordion is already open.

Diffs

New stuff ✨

• Added new waitForCondition utility function
• Added new waitForDbAfterExtensionSettingsChange function which is called on save changes with configurable extensions to ensure extension data is refetched after the change in settings is applied

Changes 🏗

• Added new useEffect to MultiSigSettings component to compare domain thresholds against the global threshold and toggle the accordion open if any domain thresholds do not match

Resolves #3598
Resolves #3034

[mmioana]

Hey @iamsamgibbs thanks for your super nice fix 🥇 👏

Tested updating the global threshold and upon returning to the extension page, the value is still displayed

Screen.Recording.2024-11-27.at.12.10.02.mov

Also if we update the threshold per team, the values get saved and upon return to the extension page, this section is toggled on

Screen.Recording.2024-11-27.at.12.10.44.mov

Just one thing that I have noticed: if you try to save the same values, after the timeout expires, an error toast is shown

Screen.Recording.2024-11-27.at.12.36.52.mov

So I'm wondering if there is anything we can do about it (maybe not show the Save settings button if the values are identical with the already saved ones) or even if it makes sense to solve this issue in this PR. What do you think @iamsamgibbs?

[iamsamgibbs]

Just one thing that I have noticed: if you try to save the same values, after the timeout expires, an error toast is shown

I actually tried to implement hiding the save button as you suggested, but it turns out to be a bit of a pain. There is already an isDirty check to show / hide the button, but it doesn't reset itself if you re-select the same values. So yes to implement properly will require comparing all the form values against the currently saved values which is a bit more involved. I'll open a new issue for it. :)

[mmioana]

Thanks @iamsamgibbs! Then I'll approve this PR 💪

[iamsamgibbs]

Created new issue #3783 to handle this

[rdig]

Tested this all without refreshing and all values show up as expected. Nicely fixed!

Screencast.from.2024-11-28.12-25-58.mp4

[bassgeta]

waitForCondition is such a great helper, kudos, we'll be able to use this to solve a lot of cases, (looking at you PaymentBuilderWidget 👀 )
The threshold is correctly updated ✔️ And I can also confirm that I could immediately start craeting multisig actions when I had enough memebrs
https://github.com/user-attachments/assets/84edac2b-2ded-471b-985f-aeb3e7c05ef9

I have however found a bug which.... I hope won't be too much of a pain to solve :')
If you set the global threshold to something else, it will update it, but not the domain values, so it opens the accordion.
I couldn't reproduce it 100% of the time, but basically

1. set the threshold to 2, refresh the page
2. set the threshold to 1 and see that the accordion opens and the previous values are used
   Attaching a video where you can see how this failed to happen the first time, but it happened the second time 🤷

multisig-threshold-bug-2024-11-28_11.46.05.mp4