Fix: Correctly keep track of form field value updates when redoing an action #3789
+35
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue was that, the
defaultValues
dependency was unstable. And so the hook in charge of initialising the form kept on resetting the form to use the default values. So even if Olga was setting the decision field to "Staking", under the hood, it kept on resetting back to "Decision". Fry doesn't have permissions in that scenario, hence the error banner.This PR introduces a new hook called
useStableDepsEffect
which basically uses lodash'sisEqual
function to perform a comparison for the dependencies. So now, even if thedefaultValues
has a different reference on re-render, because its contents are identical each time, it won't cause the effect to run:Testing
Resolves #3777 #3703