-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Adjust the input allowed for the Claim Delay input field #3794
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start on this issue @rumzledz 🙌
Unfortunately I can still reproduce the issue upon initially entering a space
Screen.Recording.2024-11-28.at.10.06.02.mov
Also noticed this error in the console
So probably we need to add this prop to the input field value={field.value ?? ''}
Also left a comment for how we should update the if
condition for the issue to not be present anymore on this field. However, please feel free to be ✨ creative ✨
if (formattedValue === field.value) { | ||
return; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my testing, in order to avoid the issue upon initially entering a space, I believe we have to update this condition to
if (
(!field.value && !formattedValue) ||
formattedValue === field.value
) {
return;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that pesky space... thanks for this @mmioana !
3e7f60d
to
3f10fb2
Compare
3f10fb2
to
ac0adb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
I'm just simply doing a check to see if the most recent version of the input conforms with our cleave rule. If not, then don't allow the field value to be updated.
Testing
Resolves #3479