Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature flag to arbitrary transactions #3799

Open
wants to merge 1 commit into
base: feat/3732-meatball-arbitrary-txs
Choose a base branch
from

Conversation

Nortsova
Copy link
Contributor

Description

Add ARBITRARY_TXS_ACTION feature flag to disable arbitrary transactions on prod

Testing

Step 1. Ensure that you have a QA or local API keys for POSTHOG
Step 2. Open any motion
Step 3. Verify that you can see Arbitrary transactions in Action Type list:
image

Step 4. Navigate to src/context/FeatureFlagsContext/FeatureFlagsContextProvider.tsx and update like 46 with:

{
        isEnabled: false,
        isLoading: false,
      }
image

Step 5. Ensure that there is no "Arbitrary transactions" in Motion Action Type list:
image

Resolves #3797

@Nortsova Nortsova requested a review from a team as a code owner November 27, 2024 18:45
Copy link
Collaborator

@jakubcolony jakubcolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here, I tested it by disabling the flag in Posthog.

Flag enabled:
image
image

Flag disabled:
image

image

Nice job! 👍

Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and thanks for picking up this issue @Nortsova 🤩

The Arbitrary transaction shows up in the list
Screenshot 2024-11-28 at 08 59 31

Changing the feature flag config
Screenshot 2024-11-28 at 09 00 05

The Arbitrary transaction no longer shows up in the list
Screenshot 2024-11-28 at 09 00 07

In Posthog all environments have the feature flag set-up 💪
Screenshot 2024-11-28 at 09 00 32

🌟

@Nortsova Nortsova self-assigned this Nov 28, 2024
Copy link
Contributor

@rumzledz rumzledz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And for @Nortsova's next magic trick, making the Arbitrary Transaction option disappear from the Action types list! 🎩 🪄

Before editing our feature flags

Screenshot 2024-11-28 at 20 40 23

Feature flag edit

Screenshot 2024-11-28 at 20 40 59

After editing our feature flags

Screenshot 2024-11-28 at 20 41 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants