Fix: Make our app automatically aware of new Colony Contributors

[rumzledz]

Description

Issue #3622 is a bit misleading. It's not that the app doesn't ever show the new contributor. It's just that on master, you'd have to reload the app to make our app refetch our contributors list.

So I added a subscription logic to make the app automatically aware that a new contributor has been added to a Colony.

And the result is nothing short of spectacular ✨

Testing

1. Connect Leela's wallet
2. Create a new Colony using this script:

node scripts/create-colony-url.js

3. Visit your new Colony
4. Stay on the Dashboard
5. Open an incognito tab
6. Connect Amy's wallet (Wallet 2)
7. Generate an invite code for the new Colony:

query MyQuery {
  getColonyByName(name: "your-new-colony's-name") { <<-- NOTE: Update this with your new Colony's name
    items {
      colonyMemberInviteCode
    }
  }
}

8. The result should be like this:

{
  "data": {
    "getColonyByName": {
      "items": [
        {
          "colonyMemberInviteCode": "cb488112-49af-4fd8-a666-5a3c71d35f1e"
        }
      ]
    }
  }
}

9. Copy the colonyMemberInviteCode field value i.e. "cb488112-49af-4fd8-a666-5a3c71d35f1e"
10. On the same Incognito tab, make sure that Amy's wallet is still connected
11. Visit http://localhost:9091/invite/{new-colony-name}/{colonyMemberInviteCode}
12. Proceed to join the Colony
13. Once you've successfully joined the Colony, switch back to the non-incognito window
14. VERY IMPORTANT: Please do not refresh the page
15. Open the Simple Payment form
16. Click the recipient field
17. Verify that your new user is visible on the list of Recipients
18. Visit the Members page
19. Verify that your new user is visible under the Followers tab

Resolves #3632

[iamsamgibbs]

refetcH

[rumzledz]

AH!

[Nortsova]

Hey @rumzledz , thank you for this nice fix ✨

Simple payments works as expected 🙌

However on Members page the Followers count was not updated:

And dashboard members count was not updated as well:

Thank you!

[rumzledz]

Those are irrelevant to the raised issue but sure, I'll fix it too 😂

[rumzledz]

@Nortsova There! Irrelevant fix pushed 😂 🚀

[iamsamgibbs]

I know this fixes such a small edge case that it doesn't really matter too much, but is a 2000 timeout reliable for opensearch having updated? Does it reliably take less than 2 seconds?

[rumzledz]

Hey @iamsamgibbs ! I tried to do 1 second and was able to notice an issue in like 1 out of 10 times. But I never had an issue with 2, so I stuck with 2, which also aligns with the colony contributor refetch done on the MemberContextProvider. There’s also a little loading window before the user gets to the colony after joining so it shouldn’t be too much of an issue 😄