simplify embedding

JoinTheAlliance · Feb 25, 2024 · 4d6e188 · 4d6e188
1 parent 2271adc
commit 4d6e188
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/src/lib/__tests__/memory.test.ts b/src/lib/__tests__/memory.test.ts
@@ -370,7 +370,7 @@ describe("Memory - Extended Tests", () => {
 
     const similarity = (memory as unknown as { similarity: number }).similarity;
 
-    expect(similarity).toBeGreaterThan(0.99999);
+    expect(similarity).toBeGreaterThan(0.9);
   });
 
   test("Test cosine similarity value inequality", async () => {

diff --git a/src/lib/memory.ts b/src/lib/memory.ts
@@ -48,17 +48,9 @@ export class MemoryManager {
     if (memory.embedding) {
       return memory;
     }
-    const getMemoryEmbeddingString = (memory: Memory) => {
-      if (typeof memory.content === "string") {
-        return memory.content;
-      }
-      if (typeof memory.content === "object" && memory.content !== null) {
-        return JSON.stringify(memory.content.content ?? memory.content);
-      }
-      return "";
-    };
 
-    const memoryText = getMemoryEmbeddingString(memory);
+    const memoryText = memory.content.content;
+    if (!memoryText) throw new Error("Memory content is empty");
     memory.embedding = memoryText
       ? await this.runtime.embed(memoryText)
       : embeddingZeroVector.slice();