-
-
Notifications
You must be signed in to change notification settings - Fork 64
fix: exclude assets with ?raw and ?url queries from processing #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I wonder if it should be something more like |
The official Vite documentation explicitly talks about Also, I think your pattern doesn't allow specifying future query parameters (perhaps for new transformers) that are prefixed with |
For what its worth, I think we should not worry about that right now, if a situation arises in the future where there are more special query params like that we can easily push another version then. |
If you feel that a more rigorous regular expression would be more appropriate, that's perfectly fine. From my perspective, though, it might not be necessary in this case, since "vite" expects these parameters as a suffix. As for the "future query parameters" concern, I was also considering the possibility of custom parameters that users might define through the |
Sorry this has sat for awhile. On second look, I'm wondering if this is something users would always want. E.g. (btw, it looks like |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This fixes the bug discussed in The plugin processes images with ?raw and ?url queries when it shouldn't #748.
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
PR?)
No.
Other information: