Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial experiments of adding demo usage to the ProgressIndicatorDemo #16

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

FDelporte
Copy link
Contributor

Is this the kind of demos you expect? I'm just having some issue to get it "full screen size", seems holder.prefWidthProperty().bind(container.prefWidthProperty()); is not the correct way to achieve this...

@JonathanGiles
Copy link
Owner

Looks fine. I can finalise it if you want - otherwise keep going and let me know when to review :-)

@FDelporte
Copy link
Contributor Author

Can you finalise please so I can see how you solve the full size problem. This is the most anyoing problem I always face with JavaFX. Can you add a chapter about that in your book? ;-)

Afterwards I'll check which other ProgressIndicator functions I can add with a demo.

@JonathanGiles JonathanGiles merged commit 97e9b8d into JonathanGiles:master Jul 18, 2018
@JonathanGiles
Copy link
Owner

I merged and made some improvements. Check them out and improve as desired (although it is probably good enough for now, so we can probably move on to another demo instead).

@JonathanGiles
Copy link
Owner

I did a follow-up push to show how to make the ProgressIndicator massive - it's just setting the max size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants