Add watchtower client number of backup metrics #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jontified
force-pushed
the
add-wt-metrics
branch
2 times, most recently
from
ee6a834 to
59787a0
Compare
Update dependencies affected by this upgrade through go mod tidy
Temporary commit which depends on lndclient fork for testing new features. Remove this commit before merging.
Fix spelling mistake in comment
Add collector for the numBackups and numPendingBackups from the lnd watchtower client API.
Jontified
force-pushed
the
add-wt-metrics
branch
from
59787a0 to
e66180e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR adds support for tracking the number of backups that the watchtower client has recorded.
Purpose: We are interested in keeping track of if our watchtower is functioning and making sure that the number of backups corresponds to the number of transactions is one metric we would like to use for this purpose.
Code:
This PR adds a new collector,
wt_client_collector.go, which works very similarly to previous collectors.This PR relies on an updated version of
lndclient(update here) to communicate with the watchtower client interface oflnd.Semantics:
2 metrics exposed.
num_backupsandnum_pending_backups.The metrics will not show up at all if there is no tower active.
Each metric has a towers public key label.