Address #81: Missing metric after Jagex/WOM Update #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh shoot, did I forget to rebase? |
Sharpienero
force-pushed
the
missing-enum-fix
branch
from
dcc34bd to
d6ebd93
Compare
|
If it can work with |
|
I tried to add that method to the BaseEnum class, but the changes kept getting ignored because the super getitem class was throwing a key value error. I can try again sometime tonight to get it working |
|
Swapped PCs and must've msssed something in the last push. I'll get it fixed soon but currently got busy, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #81
As per the issue, I know I didn't implement it exactly as discussed, so if you want me to take a stab at it the other way, LMK and I'll try again.