Correct using of JS and CSS

JoomlaLABS · Aug 23, 2020 · 340ea4e · 340ea4e
1 parent ff9ab41
commit 340ea4e
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 10 deletions.
diff --git a/src/imagecomparisonslider.css → media/css/imagecomparisonslider.css b/src/imagecomparisonslider.css → media/css/imagecomparisonslider.css
@@ -1,6 +1,13 @@
-/*
-    Code inspired from Image Comparison Slider
-    https://github.com/CodyHouse/image-comparison-slider
+/**
+ * Image Comparison Slider
+ * A handy draggable slider to quickly compare 2 images, powered by CSS3 and jQuery.
+ * https://github.com/CodyHouse/image-comparison-slider
+ *
+ * Copyright CodyHouse - https://codyhouse.co
+ *
+ * Released under the MIT License
+ *
+ * Released on: May 2, 2016
  */
 
 .cs-image-container {

diff --git a/src/imagecomparisonslider.js → media/js/imagecomparisonslider.js b/src/imagecomparisonslider.js → media/js/imagecomparisonslider.js
@@ -1,6 +1,13 @@
-/*
-    Code inspired from Image Comparison Slider
-    https://github.com/CodyHouse/image-comparison-slider
+/**
+ * Image Comparison Slider
+ * A handy draggable slider to quickly compare 2 images, powered by CSS3 and jQuery.
+ * https://github.com/CodyHouse/image-comparison-slider
+ *
+ * Copyright CodyHouse - https://codyhouse.co
+ *
+ * Released under the MIT License
+ *
+ * Released on: May 2, 2016
  */
 
 jQuery(document).ready(function($){

diff --git a/mod_joomlalabs_imagecomparisonslider_module.xml b/mod_joomlalabs_imagecomparisonslider_module.xml
@@ -7,17 +7,22 @@
 	<authorUrl>https://joomlalabs.com</authorUrl>
 	<copyright>Copyright (C) 2015 - 2020 Joomla!LABS. All rights reserved.</copyright>
 	<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
-	<version>1.0.1</version>
+	<version>1.1.0</version>
 	<description>MOD_JOOMLALABS_IMAGECOMPARISONSLIDER_MODULE_XML_DESCRIPTION</description>
 
 	<files>
 		<filename module="mod_joomlalabs_imagecomparisonslider_module">mod_joomlalabs_imagecomparisonslider_module.php</filename>
 		<folder>tmpl</folder>
 		<folder>language</folder>
-		<folder>src</folder>
+		<folder>media</folder>
 		<filename>mod_joomlalabs_imagecomparisonslider_module.xml</filename>
 	</files>
 
+	<media destination="mod_joomlalabs_imagecomparisonslider_module" folder="media">
+		<folder>css</folder>
+		<folder>js</folder>
+	</media>
+
 	<!-- Update servers -->
 	<updateservers>
 		<server type="extension" priority="1" name="Joomla!LABS Image Comparison Slider Module Update Server">

diff --git a/tmpl/default.php b/tmpl/default.php
@@ -10,9 +10,10 @@
 
 defined('_JEXEC') or die;
 
+
 $document = $app->getDocument();
-$document->addStyleSheet('/modules/mod_joomlalabs_imagecomparisonslider_module/src/imagecomparisonslider.css');
-$document->addScript('/modules/mod_joomlalabs_imagecomparisonslider_module/src/imagecomparisonslider.js');
+$document->addStyleSheet('/media/mod_joomlalabs_imagecomparisonslider_module/css/imagecomparisonslider.css', array('version' => 'auto'));
+$document->addScript('/media/mod_joomlalabs_imagecomparisonslider_module/js/imagecomparisonslider.js', array('version' => 'auto'));
 
 // Access to module parameters
 $left_image = $params->get('left_image');