fix the bug where population controller does not update the total weight #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght after rescaling
|
@Jinghong-Zhang - could you update the failing tests so that the CI tests can pass? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code does not update the total weight in the population controller which causes the total weight to decay exponentially. As a result, after several steps, the total weight of the walkers will be small so that at each step the weights will be capped by the weight bound which is 0.1x the total weight, then the rescaling in the population controller does not have any effect since it will immediately get capped in the next step.
The fix is updating the total weight stored in the population controller as we rescale the weights of the walkers.