Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#220): error when notification has null timestamp #221

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix(#220): error when notification has null timestamp #221

merged 1 commit into from
Oct 23, 2023

Conversation

ckelwin
Copy link
Collaborator

@ckelwin ckelwin commented Oct 22, 2023 •
edited
Loading

Fixes #220

Fixed:

  • null timestamp issue
  • datetime formatting.

image

@ckelwin
fix(#220): Fixed error when notification has null timestamp. Updated …
cba844c 
…datetime formatting to show time correctly for 'PM'.
@ckelwin ckelwin changed the base branch from master to dev October 22, 2023 12:18
JordyHers
JordyHers approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@JordyHers JordyHers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JordyHers JordyHers merged commit b71cf66 into dev Oct 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordyHers JordyHers JordyHers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckelwin @JordyHers