Skip to content

UiSelect: disable scroll to top when using multiple #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plakak wants to merge 1 commit into
base: next
Choose a base branch
from
Open

UiSelect: disable scroll to top when using multiple #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/UiSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
ref="options"

:highlighted="highlightedIndex === index"
:keys="keys"
:keys="keysMapping"
:key="index"
:multiple="multiple"
:option="option"
Expand Down Expand Up @@ -258,7 +258,8 @@ export default {
isTouched: false,
selectedIndex: -1,
highlightedIndex: -1,
initialValue: JSON.stringify(this.value)
initialValue: JSON.stringify(this.value),
keysMapping: this.keys
};
},

Expand Down Expand Up @@ -332,14 +333,14 @@ export default {
if (this.multiple) {
if (this.value.length > 0) {
return this.value
.map(value => value[this.keys.label] || value)
.map(value => value[this.keysMapping.label] || value)
.join(this.multipleDelimiter);
}

return '';
}

return this.value ? (this.value[this.keys.label] || this.value) : '';
return this.value ? (this.value[this.keysMapping.label] || this.value) : '';
},

hasDisplayText() {
Expand All @@ -363,11 +364,11 @@ export default {

if (Array.isArray(this.value)) {
return this.value
.map(option => option[this.keys.value] || option)
.map(option => option[this.keysMapping.value] || option)
.join(',');
}

return this.value[this.keys.value] || this.value;
return this.value[this.keysMapping.value] || this.value;
}
},

Expand All @@ -379,6 +380,14 @@ export default {

query() {
this.$emit('query-change', this.query);
},

keys(newValue, oldValue) {
// Protects agains re-renders if keys value didn't change (but reference did)
// Occures when keys are provided directly in the template and prop upates on each model change
if (!looseEqual(newValue, oldValue)) {
this.keysMapping = newValue;
}
}
},

Expand Down Expand Up @@ -486,7 +495,7 @@ export default {
},

defaultFilter(option, query) {
let text = option[this.keys.label] || option;
let text = option[this.keysMapping.label] || option;

if (typeof text === 'string') {
text = text.toLowerCase();
Expand Down