Fix UseDefaultOnConversionFailure behavior for nullable types #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph-mosadex
approved these changes
Oct 17, 2024
twinee
force-pushed
the
patch-1
branch
4 times, most recently
from
363f6a8 to
f54ad33
Compare
…fault value is null Setting a default value for a member with a nullable type with `UseDefaultOnConversionFailure` set to `true` will not use that default value when a conversion failure occurs, but throws a `TypeConverterException` instead. This is intuitive behavior and seems like a bug. This code fixes the type comparison when the default value is set to `null` so that the code behaves like one would expect. [discussion](JoshClose#2156 (comment)) closes JoshClose#2156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
nullas the default value for a member with a nullable type withUseDefaultOnConversionFailureset totruewill not use that default value when a conversion failure occurs, but throws aTypeConverterExceptioninstead. This is unintuitive behavior and seems like a bug.This code fixes the type comparison when the default value is set to
nullso that the code behaves like one would expect.discussion
Closes #2156