Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix exported types #583

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

joel-daros
Copy link
Contributor

PR Checklist

Overview

Fixed an issue regarding the exported types definitions in the package.json :

$ npx -y @arethetypeswrong/cli -P

console-fail-test v0.4.0

Build tools:
- [email protected]
- [email protected]

 No problems found 🌟


┌───────────────────┬─────────────────────┐
│                   │ "console-fail-test" │
├───────────────────┼─────────────────────┤
│ node10            │ 🟢                  │
├───────────────────┼─────────────────────┤
│ node16 (from CJS) │ 🟢 (CJS)            │
├───────────────────┼─────────────────────┤
│ node16 (from ESM) │ 🟢 (ESM)            │
├───────────────────┼─────────────────────┤
│ bundler           │ 🟢                  │
└───────────────────┴─────────────────────┘

💖

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks @joel-daros!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 09a48e2 into JoshuaKGoldberg:main Jul 11, 2024
11 checks passed
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @joel-daros for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @joel-daros! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

Copy link

🎉 This is included in version v0.4.1 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Jul 11, 2024
Adds @joel-daros as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#583 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Export types
2 participants