Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency prettier to v3.4.2 #660

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 29, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) 3.3.3 -> 3.4.2 age adoption passing confidence

Release Notes

prettier/prettier (prettier)

v3.4.2

Compare Source

diff

Treat U+30A0 & U+30FB in Katakana Block as CJK (#​16796 by @​tats-u)

Prettier doesn't treat U+30A0 & U+30FB as Japanese. U+30FB is commonly used in Japanese to represent the delimitation of first and last names of non-Japanese people or “and”. The following “C言語・C++・Go・Rust” means “C language & C++ & Go & Rust” in Japanese.

<!-- Input (--prose-wrap=never) -->

C言
語
・
C++
・
Go
・
Rust

<!-- Prettier 3.4.1 -->
C言語・ C++ ・ Go ・ Rust

<!-- Prettier 3.4.2 -->
C言語・C++・Go・Rust

U+30A0 can be used as the replacement of the - in non-Japanese names (e.g. “Saint-Saëns” (Charles Camille Saint-Saëns) can be represented as “サン゠サーンス” in Japanese), but substituted by ASCII hyphen (U+002D) or U+FF1D (full width hyphen) in many cases (e.g. “サン=サーンス” or “サン=サーンス”).

Fix comments print on class methods with decorators (#​16891 by @​fisker)
// Input
class A {
  @&#8203;decorator
  /** 
   * The method description
   *
  */
  async method(foo: Foo, bar: Bar) {
    console.log(foo);
  }
}

// Prettier 3.4.1
class A {
  @&#8203;decorator
  async /**
   * The method description
   *
   */
  method(foo: Foo, bar: Bar) {
    console.log(foo);
  }
}

// Prettier 3.4.2
class A {
  @&#8203;decorator
  /**
   * The method description
   *
   */
  async method(foo: Foo, bar: Bar) {
    console.log(foo);
  }
}
Fix non-idempotent formatting (#​16899 by @​seiyab)

This bug fix is not language-specific. You may see similar change in any languages. This fixes regression in 3.4.0 so change caused by it should yield same formatting as 3.3.3.

// Input
<div>
  foo
  <span>longlonglonglonglonglonglonglonglonglonglonglonglonglonglongl foo</span>
  , abc
</div>;

// Prettier 3.4.1 (first)
<div>
  foo
  <span>
    longlonglonglonglonglonglonglonglonglonglonglonglonglonglongl foo
  </span>, abc
</div>;

// Prettier 3.4.1 (second)
<div>
  foo
  <span>longlonglonglonglonglonglonglonglonglonglonglonglonglonglongl foo</span>
  , abc
</div>;

// Prettier 3.4.2
<div>
  foo
  <span>longlonglonglonglonglonglonglonglonglonglonglonglonglonglongl foo</span>
  , abc
</div>;

v3.4.1

Compare Source

diff

Remove unnecessary parentheses around assignment in v-on (#​16887 by @​fisker)
<!-- Input -->
<template>
  <button @&#8203;click="foo += 2">Click</button>
</template>

<!-- Prettier 3.4.0 -->
<template>
  <button @&#8203;click="(foo += 2)">Click</button>
</template>

<!-- Prettier 3.4.1 -->
<template>
  <button @&#8203;click="foo += 2">Click</button>
</template>

v3.4.0

Compare Source

diff

🔗 Release Notes


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (c3c6e4c) to head (0f48b7f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #660   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files          18       18           
  Lines        1408     1408           
  Branches      133      133           
=======================================
  Hits         1380     1380           
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/prettier-3.x-lockfile branch from 181d0c3 to 4a1a411 Compare November 29, 2024 10:30
@renovate renovate bot changed the title chore(deps): update dependency prettier to v3.4.0 chore(deps): update dependency prettier to v3.4.1 Nov 29, 2024
@renovate renovate bot force-pushed the renovate/prettier-3.x-lockfile branch 23 times, most recently from 327eac5 to b28fab0 Compare December 6, 2024 11:26
@renovate renovate bot changed the title chore(deps): update dependency prettier to v3.4.1 chore(deps): update dependency prettier to v3.4.2 Dec 7, 2024
@renovate renovate bot force-pushed the renovate/prettier-3.x-lockfile branch 2 times, most recently from 204567d to 9ae1606 Compare December 9, 2024 20:32
@renovate renovate bot force-pushed the renovate/prettier-3.x-lockfile branch 12 times, most recently from bc672e7 to 3d00307 Compare January 18, 2025 21:44
@renovate renovate bot force-pushed the renovate/prettier-3.x-lockfile branch 5 times, most recently from 754d840 to 88af59e Compare January 19, 2025 21:48
@michaelfaith michaelfaith force-pushed the renovate/prettier-3.x-lockfile branch from ac410cf to ae0865a Compare January 19, 2025 22:03
@michaelfaith michaelfaith self-requested a review January 19, 2025 22:04
Copy link
Contributor Author

renovate bot commented Jan 19, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

renovate bot and others added 2 commits January 19, 2025 16:23
This change applies changed formatting from the latest version of prettier to the codebase.
@michaelfaith michaelfaith force-pushed the renovate/prettier-3.x-lockfile branch from ae0865a to 972ffe7 Compare January 19, 2025 22:24
This change applies changed formatting from the latest version of prettier to the codebase.
This change applies changed formatting from the latest version of prettier to the codebase.
This change applies changed formatting from the latest version of prettier to the codebase.
@michaelfaith
Copy link
Collaborator

Seems to be a prettier bug. The cspell disable comment is being moved to a different place (in a cycle) everytime you run prettier.

@michaelfaith
Copy link
Collaborator

This has been reported as a newly introduced bug: prettier/prettier#16936

@michaelfaith michaelfaith added the status: blocked Waiting for something else to be resolved label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file status: blocked Waiting for something else to be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant