Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix including issue when using libchardet as a library #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lifegpc
Copy link

@lifegpc lifegpc commented Jul 6, 2021

fix this including issue
image

@Neustradamus
Copy link

@Joungkyun: What do you think about this PR?

@Joungkyun
Copy link
Owner

@Neustradamus

I don't know the environment where that error occurs.
Is it building libchardet using the build environment of ffplay-starter?
I think I just need to add -I ../include to CPPFLAGS,
First of all, I've been waiting to do this patch together if there's another patch, but I haven't had another update distance for 4 years, so I'm waiting. It's a little ambiguous to update the version with just this.

In your opinion,

When you build alone, or when you build using the build environment of another program, do you think this patch satisfies both conditions enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants