Skip to content

Commit

Permalink
Refactor (#162)
Browse files Browse the repository at this point in the history
* Remove uncessary files.

* Remove the version from package.json

It’s incorrect and not necessary since we are not publishing an real NPM project.

* Fix security issues, namely serialize-javascript.

* Move colors into their own data file.

* Refactor: Buttons

* Refactor: Icon

* Refactor: Logo

* Refactor: Action list

* Refactor: Card

* Refactor: Hero

* Refactor: Link list

* Refactor: List block

* Refactor: List group

* Refactor: Postcard

* Refactor: Step

* Refactor: Tile

* Refactor: Timeline item

* Refactor: Accordion

* Refactor WIP: Datefinder

* Refactor: Read more

* Refactor: Header group

* Refactor:  Card Section

* Refactor: Choice Section

* Refactor: Modal

* Refactor: Steps

* Refactor: Switchboard

* Refactor: Text Section

* Refactor: Timeline

* Refactor: Basic page

* Refactor: Choice

* Refactor: Choice Results

* Refactor: Onramp

* Refactor: Service

* Refactor WIP: Pages

* Refactor: Remove unused data.

* Rebuild scripts.

* Rebuild after rebase.

* Fix duplicate colliding font issue

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'public/fonts/lato/Lato-Bold.ttf'
  'public/fonts/lato/lato-bold.ttf'
  'public/fonts/lato/Lato-Regular.ttf'
  'public/fonts/lato/lato-regular.ttf'
  'public/fonts/lora/Lora-Bold.ttf'
  'public/fonts/lora/lora-bold.ttf'
  'public/fonts/lora/Lora-BoldItalic.ttf'
  'public/fonts/lora/lora-boldItalic.ttf'
  'public/fonts/lora/Lora-BoldItalic.woff2'
  'public/fonts/lora/Lora-Bolditalic.woff2'
  'public/fonts/lora/Lora-Regular.ttf'
  'public/fonts/lora/lora-regular.ttf'
  'source/fonts/lato/Lato-Bold.ttf'
  'source/fonts/lato/lato-bold.ttf'
  'source/fonts/lato/Lato-Regular.ttf'
  'source/fonts/lato/lato-regular.ttf'
  'source/fonts/lora/Lora-Bold.ttf'
  'source/fonts/lora/lora-bold.ttf'
  'source/fonts/lora/Lora-BoldItalic.ttf'
  'source/fonts/lora/lora-boldItalic.ttf'
  'source/fonts/lora/Lora-BoldItalic.woff2'
  'source/fonts/lora/Lora-Bolditalic.woff2'
  'source/fonts/lora/Lora-Regular.ttf'
  'source/fonts/lora/lora-regular.ttf'

* Fix Lato-Semibold to Lato-SemiBold, which is what the CSS refers to.

* Add data inheritance plugin; update dependencies.

* Refactor: Basic page data.

* Refactor: Choice results data.

* Refactor: Tab section

* Fix code style.

* Refactor: Service tab section

* Refactor:  Choice results to use join and nested components via data.

* Minor data tweaks/fixes in Switchboard and Basic page.

* Refactor: Autospacing test page data.

* Refactor: Switchboard urls to pages.

* Refactor: Debt collection, general info, bank levy pages.

* Refactor: Lien against real property page.

* Refactor: Negotiating a Settlement

* Refactor: Remove unecessary defaults from judgment pages.

* Refactor: Pay in Installments and Wage Garnishment pages.

* Refactor:  Partial data cleanup for Name Change and Services pages.

* Refactor: Jump Nav

* Refactor: Move autospacing to a new “Tests” category.

* Refactor: Jump nav - ensure there are no <li> when there are empty array items.

* Refactor: Move template items back to top-level.

* Refactor: Onramp FL-300 page data.

Note: Extends (which should not really be used in PL) allows the data to be inherited properly, even though it’s in not in the lineage.

* Refactor: Header Nav

* Refactor: Side Nav

* Fix: Safari issue with Modal component.

* Fix: Use unique id’s for timeline on Negotiating a Settlement page.

* Refactor: Use the read-more block variant directly! 🎉

* Refactor: Fix parsing errors.

* Refactor: Let hero data be top-level.

* Refactor: Use list-group in data.

* Refactor: Don’t print empty <li>’s due to empty array items.

* Refactor: Fix some broken ids.

* Use molecules-list-block-files variant directly.

* Downgrade everything. Netlify only supports PHP 5.6.

* Refactor: Datefinder

* Refactor: Fix icons. Do not explicitly pass the icon file.

This is set globally, and will merge with the default in icon.yml.

* Refactor: Finally fixed icon sprites, now in source directly.

* Refactor: Additional data cleanup.

* Refactor: Datefinder: Remove icon data.

* Refactor: Include datefinder pattern directly in data.

* Refactor: Checkbox: Fix duplicate ID issues.

* Refactor: Date input: Fix duplicate ID issues.

* Refactor: Icons: Include sprite directly in source.

* Rebuilt assets.
  • Loading branch information
jacine authored and slowbot committed Jan 14, 2020
1 parent 5f91b0a commit b7e82af
Show file tree
Hide file tree
Showing 185 changed files with 2,616 additions and 3,436 deletions.
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
"pattern-lab/styleguidekit-twig-default": "^3.0.0",
"pattern-lab/drupal-twig-components": "^2.0.0",
"aleksip/plugin-data-transform": "^1.0.0",
"ajgl/breakpoint-twig-extension": "^0.3.4"
"ajgl/breakpoint-twig-extension": "^0.3.4",
"pattern-lab/plugin-data-inheritance": "^1.0"
},
"scripts": {
"server": "php core/console --server",
Expand Down
75 changes: 66 additions & 9 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions config.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
"images": {
"public_images": "public/img"
},
"icons": {
"sprite_src": "source/images/icomoon/symbol-defs.svg",
"sprite_dest": "source/_patterns/01-atoms/icons"
},
"js": {
"src": ["source/js/*.js", "source/js/**/*.js", "source/_patterns/**/*.js"],
"dest": "public/js"
Expand Down
2 changes: 2 additions & 0 deletions config/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,5 @@ plugins:
dataTransform:
enabled: true
verbose: false
dataInheritance:
enabled: true
2 changes: 1 addition & 1 deletion config/listeners.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"listeners":["\\aleksip\\DataTransformPlugin\\PatternLabListener"]}
{"listeners":["\\aleksip\\DataTransformPlugin\\PatternLabListener","\\PatternLab\\DataInheritance\\PatternLabListener"]}
Empty file removed [email protected]
Empty file.
Empty file removed gulp
Empty file.
6 changes: 5 additions & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ const copyPlStyles = () => {
return gulp.src(config.css.styleguide_src).pipe(gulp.dest(config.css.styleguide_public_folder));
};

const copyIconSprite = () => {
return gulp.src(config.icons.sprite_src).pipe(gulp.dest(config.icons.sprite_dest));
};

const plCss = () => {
const plugins = [
// Pack media queries
Expand Down Expand Up @@ -171,7 +175,7 @@ const serve = cb => {
});
};

const build = gulp.series(plPhp, copyUswdsFonts, copyUswdsImages, plCss, plJs);
const build = gulp.series(plPhp, copyUswdsFonts, copyUswdsImages, copyIconSprite, plCss, plJs);

exports.build = build;
exports.default = gulp.series(build, serve, watch);
Loading

0 comments on commit b7e82af

Please sign in to comment.