Skip to content

Rm symbolic regression from integration tests #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ablaom merged 3 commits into from
Jun 3, 2025
Merged

Rm symbolic regression from integration tests #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21c4eba
rm SymbolicRegression because tests are too long
ablaom May 29, 2025
2ee1439
re-instate integration test for RecursiveFeatureElimination
ablaom May 29, 2025
d7d1d5a
bump 0.20.8
ablaom Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MLJ"
uuid = "add582a8-e3ab-11e8-2d5e-e98b27df1bc7"
authors = ["Anthony D. Blaom <[email protected]>"]
version = "0.20.7"
version = "0.20.8"

[deps]
CategoricalArrays = "324d7699-5711-5eae-9e2f-1d82baa6b597"
Expand Down
15 changes: 4 additions & 11 deletions test/integration.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,9 @@ FILTER_GIVEN_ISSUE = Dict(
"MultiTaskLassoCVRegressor",
"MultiTaskLassoRegressor",
],
"https://github.com/JuliaAI/FeatureSelection.jl/issues/15" =>
model -> model.package_name == "FeatureSelection" &&
model.name == "RecursiveFeatureElimination",
"https://github.com/sylvaticus/BetaML.jl/issues/75" =>
model -> model.package_name == "BetaML" &&
model.name == "NeuralNetworkClassifier",
"https://github.com/MilesCranmer/SymbolicRegression.jl/issues/390" =>
model -> model.package_name == "SymbolicRegression" &&
model.name == "SRRegressor",
# "https://github.com/JuliaAI/Imbalance.jl/issues/103" =>
# model -> model.package_name == "Imbalance",
)
Expand Down Expand Up @@ -140,7 +134,8 @@ for model in WITHOUT_DATASETS
end

# Additionally exclude some models for which the inferred datasets have a model-specific
# pathology that prevents valid generic test.
# pathology that prevents valid generic test, or for some other reason requiring complete
# exclusion from testing.

PATHOLOGIES = filter(MODELS) do model
# in the subsampling occuring in stacking, we get a Cholesky
Expand All @@ -156,10 +151,8 @@ PATHOLOGIES = filter(MODELS) do model
(model.name == "LOCIDetector" && model.package_name == "OutlierDetectionPython") ||
# TO REDUCE TESTING TIME
model.package_name == "MLJScikitLearnInterface" ||
# can be removed after resolution of
# https://github.com/JuliaAI/FeatureSelection.jl/issues/15
# and a Model Registry update
model.name == "RecursiveFeatureElimination"
# "https://github.com/MilesCranmer/SymbolicRegression.jl/issues/390" =>
model.package_name == "SymbolicRegression"
end

WITHOUT_DATASETS = vcat(WITHOUT_DATASETS, PATHOLOGIES)
Expand Down