Skip to content

Make Rate addition convention independent - #53

Closed
alecloudenback wants to merge 1 commit into
mainfrom
fix/commutative-rate-addition
Closed

alecloudenback wants to merge 1 commit into
mainfrom
fix/commutative-rate-addition

Conversation

@alecloudenback

Copy link
Copy Markdown
Member

Summary

  • define Rate + Rate as addition of continuous forces
  • return a Continuous rate so results do not depend on operand order
  • preserve existing nominal-space semantics for Rate + scalar
  • update and extend rate algebra tests

Testing

  • full FinanceCore package test suite

@alecloudenback

Copy link
Copy Markdown
Member Author

Closing. + stays as nominal addition in the left operand's compounding convention, which is how a spread is quoted.

Why. This PR changes the value of existing sums:

  • Periodic(0.04, 1) + Periodic(0.03, 1) goes from 7% to 7.12% annual, so a 30-year discount factor moves from 0.13137 to 0.12702.
  • That makes it a breaking FinanceCore change. ActuaryUtilities' IR01/CS01, defined as DV01 of base + spread, would change coordinate: IR01 on a semiannual 4% base with a continuous 1% spread moves from 0.027846 to 0.028526.
  • - stays nominal, so (a - b) + b != a.

What carries over:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant