You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Review update against FinanceModels v7.0.0 (6cb71714), 2026-10-11.
Still open as a feature; medium priority, potentially high for market-bond calibration. v7 has no explicit clean-price versus dirty-price/accrued-interest interface. Quote(price, instrument) does not carry that distinction, so callers must supply prices consistent with the modeled cashflows.
A complete solution needs settlement timing, the coupon schedule and accrued-interest convention; adding a clean/dirty label alone is insufficient. Coordinate the design with #155 and specify conversion/round-trip tests. This review did not find an existing clean-price API returning incorrect values; the issue is missing explicit support.
Activity
alecloudenback commentedon Oct 11, 2026
Review update against FinanceModels v7.0.0 (
6cb71714), 2026-10-11.Still open as a feature; medium priority, potentially high for market-bond calibration. v7 has no explicit clean-price versus dirty-price/accrued-interest interface.
Quote(price, instrument)does not carry that distinction, so callers must supply prices consistent with the modeled cashflows.A complete solution needs settlement timing, the coupon schedule and accrued-interest convention; adding a clean/dirty label alone is insufficient. Coordinate the design with #155 and specify conversion/round-trip tests. This review did not find an existing clean-price API returning incorrect values; the issue is missing explicit support.