Proposed fallback method for Datatypes not of type Float64, BigFloat and their Complex counterparts #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I just noticed this PR, are you still interested in this? Would be good to have this added |
jishnub
reviewed
Apr 4, 2023
| @@ -30,6 +30,9 @@ end | |||
| # end | |||
| # end | |||
| # else | |||
| complexroots(cfs::Vector{T}) where T = | |||
| sort(eigvals(companion_matrix(chop(cfs, 10*eps(T)))), lt = (x, y) -> real(x) < real(y) ? true : (real(x) > real(y) ? false : (imag(x) < imag(y) ? true : false)), rev=true) | |||
There was a problem hiding this comment.
Is this lexicographic ordering? In that case perhaps we might want to set the by keyword argument instead of the lt one, as by = x->(real(x), imag(x))
|
This would seem like a reasonable use for https://github.com/JuliaLinearAlgebra/GenericLinearAlgebra.jl which has eigvals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I needed to do division between two Laurent functions using the Double64 datatype from DoubleFloats.jl. I kept running into issues because the complexroots function only had methods for Float64, BigFloat and their Complex counterparts. So I here propose a more general fallback method which I have tested and works for Double64.
The sort is added ontop of the eigvals call so that the returned eigenvalues are in the same order as those returned from hesseneigvals.
Furthermore inside the roots function I have added the type inside the Circle of the filter! call otherwise there was some issues with domains.
Finally, in the if-statement of roots, the returned vector should not be hardcoded to be a Complex{Float64} but perhaps irts (as I have done) or someother way to make it more general.