Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce dependency on StaticArrays #131

Closed
wants to merge 1 commit into from

Conversation

daanhb
Copy link
Member

@daanhb daanhb commented Jan 20, 2023

This PR demonstrates that we could have StaticArraysCore as a dependency rather than StaticArrays.

I'm not sure I like it, but it does reduce load time by more than 50%. In any case this is a breaking change, because one would have to load StaticArrays in addition to DomainSets in order to do anything in more than one dimension.

@daanhb
Copy link
Member Author

daanhb commented Jan 20, 2023

#91

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 85.83% // Head: 85.83% // No change to project coverage 👍

Coverage data is based on head (897dd1e) compared to base (b2341a8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files          31       31           
  Lines        2626     2626           
=======================================
  Hits         2254     2254           
  Misses        372      372           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub
Copy link
Member

jishnub commented Jul 31, 2023

This is probably not a good idea given the way the package is designed at present, and the breakages that this would lead to. In any case, the way ahead in this direction should be by making StaticArrays a weak dependency and defining a package extension for it. StaticArraysCore is somewhat obsolete with package extensions becoming a feature.

@daanhb daanhb closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants