-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Towards version 0.8 (breaking release) #171
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 93.91% 93.81% -0.11%
==========================================
Files 27 28 +1
Lines 1842 1844 +2
==========================================
Hits 1730 1730
- Misses 112 114 +2 ☔ View full report in Codecov by Sentry. |
On exports:
Thus, the union of DomainSets 0.8 and FunctionMaps 0.1.1 is still smaller than what DomainSets used to export in 0.7. The difference lies mainly in functions that had been deprecated and have now been removed. In addition:
|
This pull request mainly completes the work that was started to factor out functionality of maps. A new package FunctionMaps.jl was created. It was present as a submodule in DomainSets v0.7, but is removed in this PR.
The functionality of DomainSets is exactly the same as in the current version 0.7.15. What is breaking is the exports.
I will list below exactly what the sets of exported symbols are. The total number of exports was reduced a little bit.
LinearAlgebra.cross
is no longer pirated to mean the cartesian product of domains. In version 0.8DomainSets.:×
is different fromLinearAlgebra.:×
. The latter is a synonym forLinearAlgebra.cross
, the former is a synonym for DomainSets.cartesianproduct (which in turn simply calls theproductdomain
functions).