Use function barriers for MulAddAccumulate
#147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on JuliaArrays/LazyArrays.jl#386. Don't think the performance in the simple benchmark below is affected by JuliaArrays/LazyArrays.jl#383
Puts the
MulAddAccumulate'scache_filldata!method behind a function barrier, cutting the number of allocations roughly in half for a very simple example. On current release:On this PR:
Doesn't really end up making as much of a difference inside
divdifffor aHalfWeighted{:a}polynomial though, e.g.gives roughly the same results. Still need to make some performance improvements there as discussed.