-
Notifications
You must be signed in to change notification settings - Fork 20
Examples #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Just the second commit actually oops |
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
===========================================
- Coverage 97.42% 23.12% -74.31%
===========================================
Files 2 2
Lines 350 333 -17
===========================================
- Hits 341 77 -264
- Misses 9 256 +247
Continue to review full report at Codecov.
|
@ssfrr Ok, I give, I can't get the makie examples to run. I think you wrote them; can you help? |
Can you be more specific about what isn’t working? Makie has changed a lot since this was written so I wouldn’t be surprised if all the makie stuff has to be basically rewritten from scratch |
Well, one change I had to make to this and the other examples is to run them only for a certain amount of time. So I replaced the
It doesn't help that I don't really understand FFT. I can paste the errors I get from running what I have if that would be helpful. |
Would it make sense to separate the Makie-related changes from the rest so that at least the rest of the examples could be updated, and then return to the Makie ones later when someone with Makie expertise has time for them? |
Sure, we can do that. |
@JeffFessler this is what I have so far