Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation of cache #124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve documentation of cache #124

wants to merge 2 commits into from

Conversation

PatrickHaecker
Copy link
Contributor

  • fix typos
  • fix typography
  • improve wording
  • split long lines

@PatrickHaecker
Improve documentation of cache
63a2351 
- fix typos
- fix typography
- improve wording
- split long lines
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (9c88eb1) to head (7c1a868).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files           1        1           
  Lines         399      399           
=======================================
  Hits          362      362           
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

omus
omus reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@omus omus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the rest of this docstring may be wrapped at 92-characters and not 80-characters

src/IterTools.jl Outdated Show resolved Hide resolved
@PatrickHaecker
Improve wording and wrapping of cache comment
7c1a868 
This was found during review by omus.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omus omus omus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatrickHaecker @codecov-commenter @omus