Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom constraints : add tests #128

Merged
merged 11 commits into from
Nov 27, 2024
Merged

Custom constraints : add tests #128

merged 11 commits into from
Nov 27, 2024

Conversation

franckgaga
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (58191fd) to head (2240065).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   98.28%   98.99%   +0.71%     
==========================================
  Files          24       24              
  Lines        3664     3673       +9     
==========================================
+ Hits         3601     3636      +35     
+ Misses         63       37      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franckgaga
Copy link
Member Author

#118 continuing the conversation here @baggepinnen

You can see the last version of the doc here:

https://juliacontrol.github.io/ModelPredictiveControl.jl/previews/PR128

@baggepinnen
Copy link
Member

Nice, this new feature is a nice addition!

Here
image

I find it a bit hard to understand what format the bold-face arguments come in, there are bold and non-bold face, capital and non capital letters. I assume these all mean something but I'm not sure what. They are somewhat defined at the top of the page in which the docstring appears, but it's still somewhat unclear since the entries in these arrays
image

are themselves arrays, making the layout of the outer array somewhat undefined. For example, is $U \in \mathbb{R}^{H_c n_u}$ or $U \in \mathbb{R}^{H_c \times n_u}$ or is $U$ a vector of vectors?

@franckgaga
Copy link
Member Author

That's a good point. I use this notation for vertical concatenation. So the boldface capital letters here are all vectors of reals.

I added details on the nomenclature a the top Plant Models, State Esrimator and Predictive Controllers pages. Details on the $\mathbf{U_e}$, $\mathbf{\hat{Y}_e}$ and $\mathbf{\hat{D}_e}$ are provided in NonLinMPC docstring extended Help.

I now call the JE and gc functions in the constructor an emit a warning with the stack trace if it fails. This should help the user for troubleshooting simple bugs in these 2 functions.

@franckgaga franckgaga merged commit bbb131b into main Nov 27, 2024
4 checks passed
@franckgaga franckgaga deleted the custom_constraints branch November 27, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants