Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max transform -> minimum possible of an array #79

Merged
merged 1 commit into from
Jun 10, 2022
Merged

max transform -> minimum possible of an array #79

merged 1 commit into from
Jun 10, 2022

Conversation

aTrotier
Copy link
Contributor

Hi,
Just a little PR :
Wavelets transform level should take the minimum value of L rather than the maximum.

I also add a test for that purpose

Related to this issue : MagneticResonanceImaging/MRIReco.jl#78

@aTrotier
Copy link
Contributor Author

aTrotier commented Jun 7, 2022

When you have time to review this PR :
Do you have some comments ?

@gummif
Copy link
Member

gummif commented Jun 10, 2022

Sorry about that. Looks good.

@gummif gummif merged commit 3451b21 into JuliaDSP:master Jun 10, 2022
@aTrotier
Copy link
Contributor Author

aTrotier commented Jun 10, 2022 via email

@aTrotier aTrotier deleted the max_transform branch June 10, 2022 09:46
@tknopp
Copy link

tknopp commented Oct 26, 2022

@gummif: Would it be possible to tag a release that includes this? Would be great, we need that in MRIReco.jl

@gummif
Copy link
Member

gummif commented Oct 27, 2022

Hi, this is in progress and should be available shortly, see #83.

@tknopp
Copy link

tknopp commented Oct 27, 2022

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants